Improvement of auto-escaping #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' modifier; add the 'force' mode to the 'escape' modifier; add the 'raw' modifier.
|
This is looking great, @Amaury ! How do you propose we release this? Do you think this calls for a new major version, i.e. Smarty v6 or a minor (v5.4)? One might argue this requires a major, because behavior is changing for existing templates that use |
wisskid
reviewed
Jun 19, 2024
|
About the release, I would say that a minor version should be enough; I don't know if anybody if really using auto-escaping and |
wisskid
reviewed
Jun 28, 2024
|
Thank you! :) |
|
In the end, do you think you will create a major version or a minor one? |
|
I'm thinking minor. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This evolution improves the auto-escaping feature.
escapemodifier has no effect when auto-escaping is enabled (when no escape format is given, or when thehtmlformat is used), to prevent double-escaping.escapemodifier (htmlall,url,urlpathinfo,quotes,javascript) are processed as we may expect, without double-escaping.forceformat of theescapemodifier allows to force double-escaping if needed.rawmodifier temporary disables auto-escaping for the expression it is used on.This Pull Request contains the source code of this evolution, as well as its documentation and unit tests.